WIP: deploy workers with the live-iso flow#1193
WIP: deploy workers with the live-iso flow#1193hardys wants to merge 15 commits intoopenshift-metal3:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
40a00ca to
948e8e7
Compare
Currently this picks the .8 IP on the controlplane network, but instead we need to reference the host/pod IP where the metal3 pod is running in the case where there is no provisioning network. This should also work fine when we do have a provisioning network so just update to always check the IP from the metal3 pod. Note that if the metal3 pod gets rescheduled it will be necessary to run generate_clouds_yaml.sh to update the clouds.yaml
When testing the virtualmedia flow, I noticed that we're leaking boot images, and also that on realclean we don't clean any dangling podman volumes.
Set the platform to openstack so we can user user_data to pass ignition data via the Ironic config-drive
To enable testing with the changes implemented in metal3-io/baremetal-operator#787 This requires an OCP build which contains this rebase openshift/baremetal-operator#125
This provides a config for the installer live-iso
Otherwise this creates an invalid config when you re-run 05_create_install_config.sh (for example to generate an updated extra_host_manifests file)
This is useful for debugging, and can be used to embed into the iso (since the userData currently isn't working with sushy-tools) e.g sudo podman run --pull=always --privileged --rm -v /dev:/dev -v /run/udev:/run/udev \ -v .:/data -w /data quay.io/coreos/coreos-installer:release iso ignition embed \ -i /data/ostest-worker-3-userdata-secret-userData.json rhcos-47.83.202102090044-0-live.x86_64-config.iso
This depends on https://review.opendev.org/c/openstack/sushy-tools/+/776660 I've been testing with export SUSHY_TOOLS_IMAGE="quay.io/higginsd/testimage:sushy" which contains that change TODO this also requires a corresponding metal3-dev-env PR
The current approach doesn't work when the provisioning network is disabled, so instead look for the pod IP, which should work in all cases.
Currently the userData approach doesn't work with sushy-tools because it uses a floppy disk, which isn't supported by RHCOS or recent qemu q35 machine types, so add the option to embed and create a per-host image.
This uses the API added in metal3-io/baremetal-operator#796 and also requires metal3-io/baremetal-operator#803 so we can avoid fully specifying all hardwaredetails fields
For development it's useful to be able to re-run the 05 script but currently this appends to any existing file
|
@hardys: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
So we pick up metal3-io/metal3-dev-env#619 This is needed for testing live-iso install ref openshift-metal3#1193 since that needs the sushy_ignore_boot_device option
So we pick up metal3-io/metal3-dev-env#619 This is needed for testing live-iso install ref openshift-metal3#1193 since that needs the sushy_ignore_boot_device option
So we pick up metal3-io/metal3-dev-env#619 This is needed for testing live-iso install ref openshift-metal3#1193 since that needs the sushy_ignore_boot_device option
So we pick up metal3-io/metal3-dev-env#619 This is needed for testing live-iso install ref openshift-metal3#1193 since that needs the sushy_ignore_boot_device option
So we pick up metal3-io/metal3-dev-env#619 This is needed for testing live-iso install ref openshift-metal3#1193 since that needs the sushy_ignore_boot_device option
So we pick up metal3-io/metal3-dev-env#619 This is needed for testing live-iso install ref #1193 since that needs the sushy_ignore_boot_device option
|
@hardys: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is a PoC which aims to demonstrate deploying additional workers using the RHCOS live-installer
Until openshift/ironic-image#150 merges this requires an upstream ironic-image
Also a recent OCP build that contains openshift/baremetal-operator#125 is required