Skip to content

WIP: deploy workers with the live-iso flow#1193

Closed
hardys wants to merge 15 commits intoopenshift-metal3:masterfrom
hardys:iso_install
Closed

WIP: deploy workers with the live-iso flow#1193
hardys wants to merge 15 commits intoopenshift-metal3:masterfrom
hardys:iso_install

Conversation

@hardys
Copy link
Copy Markdown

@hardys hardys commented Feb 24, 2021

This is a PoC which aims to demonstrate deploying additional workers using the RHCOS live-installer

Until openshift/ironic-image#150 merges this requires an upstream ironic-image

Also a recent OCP build that contains openshift/baremetal-operator#125 is required

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2021
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hardys after the PR has been reviewed.
You can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hardys hardys marked this pull request as draft February 24, 2021 16:58
@hardys hardys removed request for russellb and zaneb February 24, 2021 16:58
@hardys hardys force-pushed the iso_install branch 2 times, most recently from 40a00ca to 948e8e7 Compare February 25, 2021 13:09
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2021
Steven Hardy added 12 commits March 2, 2021 08:12
Currently this picks the .8 IP on the controlplane network, but
instead we need to reference the host/pod IP where the metal3
pod is running in the case where there is no provisioning network.

This should also work fine when we do have a provisioning network
so just update to always check the IP from the metal3 pod.

Note that if the metal3 pod gets rescheduled it will be necessary
to run generate_clouds_yaml.sh to update the clouds.yaml
When testing the virtualmedia flow, I noticed that we're
leaking boot images, and also that on realclean we don't
clean any dangling podman volumes.
Set the platform to openstack so we can user user_data to pass
ignition data via the Ironic config-drive
To enable testing with the changes implemented in
metal3-io/baremetal-operator#787

This requires an OCP build which contains this rebase
openshift/baremetal-operator#125
This provides a config for the installer live-iso
Otherwise this creates an invalid config when you re-run
05_create_install_config.sh (for example to generate an
updated extra_host_manifests file)
This is useful for debugging, and can be used to embed into the
iso (since the userData currently isn't working with sushy-tools) e.g

sudo podman run --pull=always --privileged --rm -v /dev:/dev -v /run/udev:/run/udev \
-v .:/data -w /data quay.io/coreos/coreos-installer:release iso ignition embed  \
-i /data/ostest-worker-3-userdata-secret-userData.json rhcos-47.83.202102090044-0-live.x86_64-config.iso
This depends on https://review.opendev.org/c/openstack/sushy-tools/+/776660

I've been testing with export SUSHY_TOOLS_IMAGE="quay.io/higginsd/testimage:sushy"
which contains that change

TODO this also requires a corresponding metal3-dev-env PR
The current approach doesn't work when the provisioning network
is disabled, so instead look for the pod IP, which should work
in all cases.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2021
Steven Hardy added 3 commits March 2, 2021 10:38
Currently the userData approach doesn't work with sushy-tools
because it uses a floppy disk, which isn't supported by RHCOS
or recent qemu q35 machine types, so add the option to embed
and create a per-host image.
This uses the API added in metal3-io/baremetal-operator#796
and also requires metal3-io/baremetal-operator#803
so we can avoid fully specifying all hardwaredetails fields
For development it's useful to be able to re-run the 05 script
but currently this appends to any existing file
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@hardys: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 13, 2021
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 13, 2021
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 14, 2021
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 20, 2021
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Apr 20, 2021
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref openshift-metal3#1193 since that needs
the sushy_ignore_boot_device option
openshift-merge-robot pushed a commit that referenced this pull request Apr 20, 2021
So we pick up metal3-io/metal3-dev-env#619

This is needed for testing live-iso install ref #1193 since that needs
the sushy_ignore_boot_device option
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 16, 2021

@hardys: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi 9924d78 link /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 9924d78 link true /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-ipv6 9924d78 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-serial-ipv4 9924d78 link true /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hardys hardys closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants